-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gallery icon from fictious record set #4220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with this solution if @grantfitzsimmons is ok
specifyweb/frontend/js_src/lib/components/FormSliders/RecordSelectorFromIds.tsx
Outdated
Show resolved
Hide resolved
Instructions for testers? @CarolineDenis |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gallery icon is not shown on data entry form headers or fictitious record set headers.
In a record set, gallery icon is now shown:
You get this dialog if no attachments are added upon clicking the icon:
I know that disabling the icon in this case was discussed. I don't have a preference one way or the other really but am requesting review from @grantfitzsimmons to follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Galley icon does not show up unless it is an actual record set. Even if there are no attachments the gallery icon is there, as Bronwyn said, I don't care if it is there or not, but it depends on what Grant thinks.
Fixes #4211