Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gallery icon from fictious record set #4220

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

CarolineDenis
Copy link
Contributor

Fixes #4211

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this solution if @grantfitzsimmons is ok

@CarolineDenis CarolineDenis marked this pull request as ready for review November 20, 2023 14:12
@CarolineDenis CarolineDenis requested review from maxpatiiuk and a team November 20, 2023 14:12
@pashiav
Copy link
Contributor

pashiav commented Nov 21, 2023

Instructions for testers? @CarolineDenis

@CarolineDenis
Copy link
Contributor Author

@pashiav

  • go to Data Entry
  • verify that the gallery icon is not present in the header
  • save the form and add a new one
  • save the second one
  • verify the record set icon is now present but not the gallery icon
  • click on record set icon to create a record set
  • verify that now the gallery icon is present
  • open any record set and verify gallery icon is present
  • NOTES: gallery icon is disabled if there is no attachments

Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gallery icon is not shown on data entry form headers or fictitious record set headers.
Screenshot 2023-11-22 at 10 51 36 AM
Screenshot 2023-11-22 at 10 52 39 AM

In a record set, gallery icon is now shown:
Screenshot 2023-11-22 at 10 53 28 AM

You get this dialog if no attachments are added upon clicking the icon:
Screenshot 2023-11-22 at 10 53 57 AM

I know that disabling the icon in this case was discussed. I don't have a preference one way or the other really but am requesting review from @grantfitzsimmons to follow up

Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Galley icon does not show up unless it is an actual record set. Even if there are no attachments the gallery icon is there, as Bronwyn said, I don't care if it is there or not, but it depends on what Grant thinks.

@CarolineDenis CarolineDenis merged commit 682469c into xml-editor Dec 13, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4211 branch December 13, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

xml-editor: Attachment gallery button should not display unless there are attachments
5 participants