feat(Atoms): prevent numeric input from changing on scroll #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxpatiiuk
commented
Dec 2, 2023
CarolineDenis
approved these changes
Dec 4, 2023
melton-jason
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
If a numeric field is required and has no value, scrolling over it will still insert a value.
Barring that (if that is even an issue at all), this is fine!
@specify/ux-testing
When testing, please also provide your thoughts regarding focusing the field when scrolling over it!
grantfitzsimmons
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4245
To test:
Make sure that #4245 does not happen for numeric inputs in the following two places:
(those input fields look the same, but are different in the code)