Strip white-space characters when enforcing business rule #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarolineDenis
approved these changes
Dec 4, 2023
maxpatiiuk
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
can we just move on to institution prefs as fast as possible?
@realVinayak are there any major steps remaining before that migration can be done? it seems like all the major pieces are completed (UI, fetching logic, hooks, typescript types) - now just write the migration script and that's it
until we have that, fixing the old system might be a waste of time.
not to mention all the cool and requested global prefs we could add once we have this
not to mention, the new system would be separate from sp6
emenslin
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4250
Testing instructions