fix(FormEditor): form cache not being cleared #4290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of stale state, the cache for the form that was edited most recently wasn't getting cleared.
Changed to ref, since using state here didn't make sense in the first place (state isn't used in render). I used state because at the time I followed idea that we should use state whenever possible, and ref only when must, because state would be cleaner and less bug prone. However, today I belive that each has it's place - use state when you need to use the value in the render or dependency array - use ref otherwise
Fixes #1977