Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display disable Icon add button instead of link when lowest tree rank #4351

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Display disable Icon add button instead of link when lowest tree rank #4351

merged 2 commits into from
Jan 4, 2024

Conversation

CarolineDenis
Copy link
Contributor

Fixes #4349

@CarolineDenis CarolineDenis added this to the 7.9.4 milestone Jan 3, 2024
@CarolineDenis CarolineDenis linked an issue Jan 3, 2024 that may be closed by this pull request
xml-editor: Add child icon does not get disabled for node at lowest rank #4349
Closed
@CarolineDenis CarolineDenis requested a review from a team January 4, 2024 15:15
@CarolineDenis CarolineDenis marked this pull request as ready for review January 4, 2024 15:17
emenslin
emenslin approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, add child button is disabled.
Screenshot 2024-01-04 101445

@CarolineDenis CarolineDenis requested a review from a team January 4, 2024 16:49
bronwyncombs
bronwyncombs approved these changes Jan 4, 2024
View reviewed changes
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! "Add child" icon is disabled when node of lowest rank is selected.

Screenshot 2024-01-04 at 11 55 36 AM

@CarolineDenis CarolineDenis merged commit 6602fa6 into xml-editor Jan 4, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4349 branch January 4, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@bronwyncombs bronwyncombs bronwyncombs approved these changes

@emenslin emenslin emenslin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.4
Development

Successfully merging this pull request may close these issues.

xml-editor: Add child icon does not get disabled for node at lowest rank
4 participants
@CarolineDenis @maxpatiiuk @bronwyncombs @emenslin