Move side bar pref to ui + rename #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
maxpatiiuk
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
@grantfitzsimmons can we mention in the release notes that if they had this pref set, they would have to set it again since it has been moved?
or is it important enough for us to provide a small migration for this?
emenslin
requested changes
Jan 4, 2024
|
@emenslin, it's because it's available only for light mode |
bronwyncombs
approved these changes
Jan 4, 2024
I think we'll just mention this in the release notes. I don't want to do a migration for it, and only one user that I know of has configured this since it's a very new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4305