Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recompute taxonomic rank on parent change #4462

Merged
merged 7 commits into from
Feb 13, 2024
Merged

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Jan 25, 2024

Fixes #4455
and maybe #4437
Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • open data entry new taxon
  • add name
  • choose a parent of taxon that has a high rank (Acipenser)
  • wait a few seconds for the taxonomic rank to be populated
  • change the taxonomic rank to the highest rank possible (Subgenus)
  • change the parent taxon to a taxon that is lower in the tree than the taxonomic rank you chose (Brevirostrum)
  • wait a few second for the taxonomy rank to be updated
  • save
    (examples with coldFish db)
    Please test for issue 4455 and test for 4437

@CarolineDenis CarolineDenis added this to the 7.9.4 milestone Jan 25, 2024
Triggered by d85d301 on branch refs/heads/issue-4455
@CarolineDenis CarolineDenis requested review from maxpatiiuk and a team January 26, 2024 15:41
@CarolineDenis CarolineDenis marked this pull request as ready for review January 26, 2024 15:42
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it fixed the issues within the taxon tree and when entering taxon through data entry.

@CarolineDenis CarolineDenis requested a review from a team January 26, 2024 16:35
@CarolineDenis
Copy link
Contributor Author

@emenslin,
did you check if it was fixing #4455
and #4437?

@emenslin
Copy link
Collaborator

@emenslin, did you check if it was fixing #4455 and #4437?

Yes it fixed both #4455 and #4437

@CarolineDenis
Copy link
Contributor Author

@emenslin, amazing thank you!

Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed both #4455 and #4437. Looks good!

@grantfitzsimmons
Copy link
Member

@bronwyncombs Can you test to see if this fixes #2637?

Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cases in issue #2637 are covered by this pr! API call in rank no longer happens - the rank field updates appropriately in response to change in parent field. Testing with Clone and Add and changing parent field also passed without issue.

Screen.Recording.2024-02-09.at.11.08.37.AM.mov

@CarolineDenis CarolineDenis merged commit 00990cd into production Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
6 participants