-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use muted colors for taxon tiles #4476
Conversation
Replaces the d3 scheme with a custom set of colors
Triggered by 0215714 on branch refs/heads/issue-1859
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I feel like the color schemes in both light and dark mode blend in a lot better and are less jarring now. I feel like light mode might be a little bright with the white borders, however I am normally in dark mode so that's probably just a me thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great in dark mode! In light mode, I feel that it is hard to see some of the small tiles because of the light colored border and the width of it.
Aesthetically though, the colors look good! It matches the Specify color palette.
Colors are pleasing and compliment the Specify brand well. Tiles are visible/distinct in both light and dark mode, although slightly more clear in light mode, IMO. Congrats on a great idea turned successful PR @grantfitzsimmons! |
Replaces the d3 scheme with a custom set of colors that matches the previous behavior
This has been requested a few times by users since our default taxon tiles colors changed.
Fixes #1859
New Appearance
issue-1859
on left,v7.7
on right in advertisement screenshotsBackground Information
This is simply an aesthetic change
I tested all of the categorical color schemes out of the box included in d3 but none of them were satisfactory. I think Max chose the right one when it was updated, but the style that users have required
schemeSet2 (current)
Other default options:
schemeAccent
schemePaired
schemePastel2
schemeSet3
schemeTableau10
schemeSet1
schemeCategory10
schemePastel1
schemePastel2
Checklist
and self-explanatory (or properly documented)
Testing instructions