Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use muted colors for taxon tiles #4476

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Use muted colors for taxon tiles #4476

merged 5 commits into from
Feb 13, 2024

Conversation

grantfitzsimmons
Copy link
Member

Replaces the d3 scheme with a custom set of colors that matches the previous behavior

This has been requested a few times by users since our default taxon tiles colors changed.

Fixes #1859

New Appearance

issue-1859 on left, v7.7 on right in advertisement screenshots

image image

Background Information

This is simply an aesthetic change

image

I tested all of the categorical color schemes out of the box included in d3 but none of them were satisfactory. I think Max chose the right one when it was updated, but the style that users have required

schemeSet2 (current)

schemeSet2 (current)

Other default options:

schemeAccent

schemeAccent

schemePaired

schemePaired

schemePastel2

schemePastel2

schemeSet3

schemeSet3

schemeTableau10

schemeTableau10

schemeSet1

schemeSet1

schemeCategory10

schemeCategory10

schemePastel1

schemePastel1

schemePastel2

schemePastel2

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)

Testing instructions

  1. Configure the home screen to show Taxon Tiles
  2. Verify the change appears in light mode
  3. Verify the change appears in dark mode
  4. Provide feedback on the color scheme in your review

Replaces the d3 scheme with a custom set of colors
@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review January 28, 2024 18:48
@grantfitzsimmons grantfitzsimmons marked this pull request as draft January 28, 2024 18:49
@grantfitzsimmons grantfitzsimmons marked this pull request as ready for review January 28, 2024 19:06
@grantfitzsimmons grantfitzsimmons requested a review from a team January 30, 2024 16:05
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I feel like the color schemes in both light and dark mode blend in a lot better and are less jarring now. I feel like light mode might be a little bright with the white borders, however I am normally in dark mode so that's probably just a me thing.

@grantfitzsimmons grantfitzsimmons requested a review from a team January 30, 2024 20:42
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great in dark mode! In light mode, I feel that it is hard to see some of the small tiles because of the light colored border and the width of it.

Aesthetically though, the colors look good! It matches the Specify color palette.

@bronwyncombs
Copy link

Colors are pleasing and compliment the Specify brand well.

Tiles are visible/distinct in both light and dark mode, although slightly more clear in light mode, IMO.

dark mode:
Screenshot 2024-01-31 at 1 25 30 PM
light mode:
Screenshot 2024-01-31 at 1 23 15 PM

Congrats on a great idea turned successful PR @grantfitzsimmons!

@grantfitzsimmons grantfitzsimmons added this to the Grant's issue list milestone Feb 1, 2024
@grantfitzsimmons grantfitzsimmons merged commit 2adaef2 into production Feb 13, 2024
9 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-1859 branch February 13, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use more muted colors for the taxon tiles
5 participants