Always show saveBlocker dialog for unclaimed blockers #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4693 If the field is not required and the value is null or undefined, do not invalidate rule. Otherwise if field is requried and value is null or undefined, invalidate rule.
CarolineDenis
approved these changes
Mar 29, 2024
maxpatiiuk
reviewed
Mar 30, 2024
|
@specify/ux-testing When testing this, can #4705 be tested as well? You should not be able to recreate the issue on this branch |
grantfitzsimmons
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Testing instructions
- Make sure a CollectionObject from has the
collectionObjectAttributerelationship as a subview and does not have theuniqueIdentifierfield- Find an existing CollectionObject which does not have a
Col Obj Attribute- Add a Col Obj Attribute to the Collection Object and ensure a saveBlocker is not set
Can confirm that this fixes #4693
- In SchemaConfig, make
uniqueIdentifierrequired on CollectionObject- Repeat steps 2-3, but this time make sure a saveBlocker is set and a dialog appears saying uniqueIdentifier must be unique to the database
- Add uniqueIdentifier to the CollectionObject form (or use the AutoGenerated Form) and ensure the uniqueness rule functions correctly
Looks good! 👍
bronwyncombs
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
- ✅ Make sure a CollectionObject from has the
collectionObjectAttributerelationship as a subview and does not have theuniqueIdentifierfield - ✅ Find an existing CollectionObject which does not have a
Col Obj Attribute - ✅ Add a Col Obj Attribute to the Collection Object and ensure a saveBlocker is not set
- ✅ In SchemaConfig, make
uniqueIdentifierrequired on CollectionObject - ✅ Repeat steps 2-3, but this time make sure a saveBlocker is set and a dialog appears saying uniqueIdentifier must be unique to the database
- ✅ Add uniqueIdentifier to the CollectionObject form (or use the AutoGenerated Form) and ensure the uniqueness rule functions correctly
In testing for locality with #4705:
Save behaves as expected for locality records added after initial save.
Looks good!
lexiclevenger
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Testing instructions
- Make sure a CollectionObject from has the
collectionObjectAttributerelationship as a subview and does not have theuniqueIdentifierfield - Find an existing CollectionObject which does not have a
Col Obj Attribute - Add a Col Obj Attribute to the Collection Object and ensure a saveBlocker is not set
- In SchemaConfig, make
uniqueIdentifierrequired on CollectionObject - Repeat steps 2-3, but this time make sure a saveBlocker is set and a dialog appears saying uniqueIdentifier must be unique to the database
- Add uniqueIdentifier to the CollectionObject form (or use the AutoGenerated Form) and ensure the uniqueness rule functions correctly
This also fixed issue #4705.
Initially, the save was blocked, but I left the tab and returned to it after some time and it was no longer blocked. I don't know what I did, and I was not able to recreate this.
maxpatiiuk
requested changes
Apr 2, 2024
maxpatiiuk
approved these changes
Apr 2, 2024
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4693
Fixes #4705
The issue from #4693 (comment) was that adding a
Col Obj Attributeto an existing CollectionObject saved triggered aresource.changefor every field on the CollectionObject.This caused business rules to be triggered for every field.
There is a uniqueness rule for CollectionObject which states that
uniqueIdentifiermust be unique at a database level.Thus the uniqueness rule was triggered (as there are other CollectionObjects with NULL uniqueIdentifer) and the saveBlocker was set. Since the field was not present on the CollectionObject form, no indication was made to the user.
Checklist
and self-explanatory (or properly documented)
Testing instructions
collectionObjectAttributerelationship as a subview and does not have theuniqueIdentifierfieldCol Obj AttributeuniqueIdentifierrequired on CollectionObject