Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deaccession in interactions list #4806

Merged
merged 3 commits into from
May 21, 2024
Merged

Add deaccession in interactions list #4806

merged 3 commits into from
May 21, 2024

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Apr 18, 2024 •
edited

Fixes #4801

xml change:
specify/specify6#1241

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

  • open interactions side menu
  • verify deaccession is there and that you can open a new form

@CarolineDenis CarolineDenis added this to the 7.9.6 milestone Apr 18, 2024
@CarolineDenis CarolineDenis requested a review from a team May 20, 2024 15:28
@CarolineDenis CarolineDenis marked this pull request as ready for review May 20, 2024 15:28
lexiclevenger
lexiclevenger approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@lexiclevenger lexiclevenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • open interactions side menu
  • verify deaccession is there and that you can open a new form

Looks good; the deaccessions table is present and the form can be opened
Screenshot 2024-05-20 at 11 06 15 AM

@CarolineDenis CarolineDenis requested a review from a team May 20, 2024 16:32
Areyes42
Areyes42 approved these changes May 20, 2024
View reviewed changes
Copy link

@Areyes42 Areyes42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • open interactions side menu
  • verify deaccession is there and that you can open a new form

Looks good! 👍
Screenshot 2024-05-20 at 11 45 32 AM

@CarolineDenis CarolineDenis merged commit 1918644 into production May 21, 2024
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4801 branch May 21, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acwhite211 acwhite211 acwhite211 approved these changes

@Areyes42 Areyes42 Areyes42 approved these changes

@lexiclevenger lexiclevenger lexiclevenger approved these changes

@melton-jason melton-jason Awaiting requested review from melton-jason

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.6
Development

Successfully merging this pull request may close these issues.

Add Deaccession to the Interactions menu
4 participants
@CarolineDenis @acwhite211 @Areyes42 @lexiclevenger