Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1272 #1288

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Fixed #1272 #1288

merged 1 commit into from
Jan 4, 2023

Conversation

AlexandruPopovici
Copy link
Contributor

…anges were set. Implemented a draw range flattener for the PointBatch which avoids redundant draw calls, which in some cases could get into the tens of thousands killing performance entirely. Fixed an issue where gradient ramp index was not neing set correctly when it was 0

Description & motivation

This #1272 was raised, describing two issues. One with performance when applying filters on a specific stream and another one where successive gradient filters were not being applied correctly. The reported bugs were a good catch since they can potentially affect any stream

Changes:

  • Fixed an issue with PointBatch auto fill draw ranges, where invalid ranges were set, and any points in that batch would not be rendered
  • Implemented a draw range flatten-er for the PointBatch which avoids redundant draw calls, which in some cases could get into the tens of thousands killing performance entirely. This was the case in Viewer Filter's Performance and Bug #1272 where several tens of thousand of points each got their own draw group even though all of them had the same material index.
  • Fixed an issue where gradient ramp index was not being set correctly when it was 0

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

…anges were set. Implemented a draw range flattener for the PointBatch which avoids redundant draw calls, which in some cases could get into the tens of thousands killing performance entirely. Fixed an issue where gradient ramp index was not neing set correctly when it was 0
@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Jan 3, 2023
@AlexandruPopovici AlexandruPopovici merged commit 4181217 into main Jan 4, 2023
@AlexandruPopovici AlexandruPopovici deleted the alex/#1272 branch January 4, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants