feat(fe2): improved and more thorough logging to help with observability #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
reviewed
Jan 9, 2024
iainsproat
reviewed
Jan 9, 2024
iainsproat
reviewed
Jan 9, 2024
iainsproat
reviewed
Jan 9, 2024
iainsproat
reviewed
Jan 9, 2024
iainsproat
reviewed
Jan 9, 2024
iainsproat
reviewed
Jan 9, 2024
iainsproat
reviewed
Jan 9, 2024
| @@ -89,7 +89,7 @@ | |||
| "pg": "^8.7.3", | |||
| "pg-query-stream": "^4.2.3", | |||
| "pino": "^8.7.0", | |||
| "pino-http": "^8.2.1", | |||
| "pino-http": "^8.6.1", | |||
There was a problem hiding this comment.
9.0.0 is available if we're bumping this.
There was a problem hiding this comment.
i only updated it to fix TS type mismatches, I'd prefer not to go into the rabbit hole of doing a major upgrade in this PR, especially considering that the version has to be compatible across multiple packages (e.g. also @speckle/shared)
iainsproat
reviewed
Jan 9, 2024
fabis94
changed the title
iainsproat
approved these changes
Jan 10, 2024
iainsproat
reviewed
Jan 10, 2024
| const endTime = Date.now() - state.start | ||
| logger.info( | ||
| { | ||
| responseTime: endTime, |
There was a problem hiding this comment.
Should we include the units in the name?: responseTimeMs
There was a problem hiding this comment.
I'm following the convention we have in other log messages. If we change it here, it's just going to be different from everything else, so I'd rather not
There was a problem hiding this comment.
- The message makes it clear that it's
ms
iainsproat
approved these changes
Jan 11, 2024
gjedlicska
pushed a commit
that referenced
this pull request
Jan 11, 2024
…ity (#1948) * better req log text * minor improvements to server logging * WIP FE2 req logging * FE2 apollo operation logging * undid apolloPlugin changes due to Gergos PR * seq message templates introduced
gjedlicska
added a commit
that referenced
this pull request
Jan 17, 2024
* gergo/apolloQueryDuration (#1949) * add apollo query duration * feat: add more details to apollo query logging * fix: pr review * feat: format log messages as clef (#1950) * fix(logging): pinoClef log levels must be a string * chore(fe2): reducing log level for some spammy req logs * minor adjustment * more robust path resolution * better req log text * feat(fe2): improved and more thorough logging to help with observability (#1948) * better req log text * minor improvements to server logging * WIP FE2 req logging * FE2 apollo operation logging * undid apolloPlugin changes due to Gergos PR * seq message templates introduced * fix: request logs (#1964) * fix: request logs * chore: remove comments * feat: add graphql subscription metrics (#1970) * optimized preview msg resultListener * fix(server): locking to avoid postgres notification listeners processing the same message multiple times (#1972) * fix(server): locking to avoid postgres notification listeners processing the same message multiple times * optimized locking * minor cleanup * msg update * log level adjustments * reduce failsafe expiry --------- Co-authored-by: Iain Sproat <68657+iainsproat@users.noreply.github.com> Co-authored-by: Kristaps Fabians Geikins <fabis94@live.com> Co-authored-by: Kristaps Fabians Geikins <fabians@speckle.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References