Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump bcrypt and puppeteer to enable building on apple silicon #1965

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jan 11, 2024

Description & motivation

Building Docker files on mac was broken, due to previous versions of bcrypt and puppeteer not supporting it.

If running on mac it requires Docker Desktop >=4.27 with Rosetta enabled.

This is not intended to be a supported build environment, as it's never worked to date, but if we can easily get it working then that would be great 👍

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@iainsproat iainsproat marked this pull request as ready for review January 11, 2024 23:48
@iainsproat iainsproat merged commit b5f77f3 into main Jan 29, 2024
19 of 21 checks passed
@iainsproat iainsproat deleted the iain/build-apple-silicon branch January 29, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants