preview-service<-> viewer API2.0 #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version before the API 2.0 merge as a temporary solution until the preview service is updated to use API 2.0
… Went with using a LegacyViewer, since it was the easiest. preview-service is weird
didimitrie
approved these changes
Jan 12, 2024
gjedlicska
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates and fixes the preview-service to use the latest viewer version. Went with a
LegacyViewerinstance since preview-service makes it hard to develop anything inside the function that gets run in the page opened by pupeteer.Description & motivation
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References