Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE2 - Embedding #1979

Merged
merged 147 commits into from
Feb 6, 2024
Merged

FE2 - Embedding #1979

merged 147 commits into from
Feb 6, 2024

Conversation

andrewwallacespeckle
Copy link
Contributor

@andrewwallacespeckle andrewwallacespeckle commented Jan 22, 2024

Adding embed functionality to FE2. This is done through the ProjectModelPageDialogEmbed component.

This can be accessed from:

  • Project Page - Card Actions
  • Version Page - Card Actions
  • Viewer - Share Menu in Header

The dialog has an iframe preview of the embed, depending on options selected.

These options are:

  • Transparent background
  • Hide viewer controls
  • Hide the Selection Info panel
  • Prevent scrolling (zooming)
    -Load model manually
  • Comment slideshow mode
image

@andrewwallacespeckle andrewwallacespeckle mentioned this pull request Feb 1, 2024
Closed
@andrewwallacespeckle
Copy link
Contributor Author

@fabis94 These should all be done now.

There is 1 remaining issue that I'm struggling with. It is around the Dialog Section changes. I reverted the lazy load changes, and used always-open instead of guided-open. ?settings=true works, as does ?settings=access. The problem comes when you close the dialog, it reopens as an unclickable dialog. I'm not sure whats happening. I added a watch to remove the settings parameter on close, but it still has the problem. Could you take a look?

One last thing is there is a merge conflict in a file that you worked on, could you resolve the conflict? I'm not sure what is correct.

fabis94
fabis94 previously approved these changes Feb 5, 2024
@andrewwallacespeckle andrewwallacespeckle merged commit ff64331 into main Feb 6, 2024
19 of 22 checks passed
@andrewwallacespeckle andrewwallacespeckle deleted the andrew/embed-dialog branch February 6, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants