Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for aabb calculation for non-mesh objects #1992

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

Fix for a bug that caused an error to thrown when computing the aabb for non mesh objects

Description & motivation

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Jan 25, 2024
@AlexandruPopovici AlexandruPopovici self-assigned this Jan 25, 2024
@AlexandruPopovici AlexandruPopovici merged commit 2d13f73 into main Jan 25, 2024
19 of 21 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/aabb-fix branch January 25, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants