Remove findAll when matching ids

[AlexandruPopovici]

Description & motivation

In FE2 when clicking on any of the items highlighted in the image below

Which would make all the objects of the selected type to become 'selected', for a large number of objects the main thread would get blocked for tens of seconds.

60% of the execution time was taken up by using findAll when going over very many string ids, to get the tree node from the viewer. In API 2.0, this is no longer needed. Instead you use findId which is incomparably faster since it's just one or two lookups. After making this change, the viewer overhead was completely gone. However there is still some FE2 related overhead, accounting for approx 30% of the total inital overhead.

I'm leaving two profiler recordings, one before the change, one after the change. The FE2 related overhead is visible in both, and it seems to be the same one mentioned here

Changes:

• No more using findAll when trying to match object ids. Replaced with findId

To-do before merge:

Screenshots:

Before:

After:

Validation of changes:

Checklist:

• My pull request follows the guidelines in the Contributing guide?
• My pull request does not duplicate any other open Pull Requests for the same update/change?
• My commits are related to the pull request and do not amend unrelated code or documentation.
• My code follows a similar style to existing code.
• I have added appropriate tests.
• I have updated or added relevant documentation.

References

[fabis94]

I guess so? haha