Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm chart test): tests can be run in environment with self-signed certificate #1997

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

iainsproat
Copy link
Contributor

@iainsproat iainsproat commented Jan 26, 2024

Description & motivation

Local development and CI environments may not have a domain name with a trusted certificate. Instead they are likely to have self-signed certificates. This caused the test container to fail when it attempted to connect to the speckle server under test.

Changes:

  • introduces a VERIFY_CERTIFICATE environment variable
  • will verify the certificate by default, but skip if the environment variable is set to "0" (Note, zero is a string value)
  • bumps specklepy to 2.17.7, as this allows skipping of tls certificate verification
  • visual improvement of logged output

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

…ned certificate

- introduces a VERIFY_CERTIFICATE environment variable
@iainsproat iainsproat marked this pull request as ready for review January 26, 2024 16:06
@iainsproat iainsproat merged commit c979c97 into main Jan 26, 2024
19 of 21 checks passed
@iainsproat iainsproat deleted the iain/helm-chart-testing-improve-test branch January 26, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant