Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Text with Null Material/DisplayStyle #2016

Merged
merged 2 commits into from Feb 7, 2024

Conversation

AlexandruPopovici
Copy link
Contributor

@AlexandruPopovici AlexandruPopovici commented Feb 6, 2024

Description & motivation

The viewer now supports text with no specified material/display style by defining it's own default text null material, similarly to how all the rest of the object types have

Changes:

  • Materials now defines it's null text material hash + material
  • TextBatch now properly computes it's bounds

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlexandruPopovici AlexandruPopovici added the [ viewer ] issues related to the 3d viewer package label Feb 6, 2024
@AlexandruPopovici AlexandruPopovici merged commit 6a5f7bb into main Feb 7, 2024
1 of 9 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/null-text-material branch February 7, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[ viewer ] issues related to the 3d viewer package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants