Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DUI: Preview error image uses 360 previews logic instead of being static. #1960

Closed
AlanRynne opened this issue Dec 1, 2022 · 0 comments
Closed

DUI: Preview error image uses 360 previews logic instead of being static. #1960

AlanRynne opened this issue Dec 1, 2022 · 0 comments
Assignees
@teocomi
Labels
bug Something isn't working
Milestone
2.x

Comments

@AlanRynne
Copy link
Member

An image is worth a 1000 words 馃憞馃徏

2022-12-01 10 57 10

When the preview image is not available, we should disable the mouse magic that applies to our 360 previews.

Either that... or have a super cool 360 preview error image 馃槄
@AlanRynne AlanRynne added the bug Something isn't working label Dec 1, 2022
@AlanRynne AlanRynne added this to the 2.x milestone Dec 1, 2022
teocomi added a commit that referenced this issue Dec 1, 2022
@teocomi
fix(dui): preview issues #1961 #1960
04a75fc
@teocomi teocomi mentioned this issue Dec 1, 2022
Merged
AlanRynne pushed a commit that referenced this issue Dec 6, 2022
@teocomi
fix(dui): preview issues #1961 #1960 (#1964)
22b8bbf 
* fix(dui): preview issues #1961 #1960

* fix(dui): ensures preview state is reset when changing branch
@teocomi teocomi closed this as completed Dec 6, 2022
This was referenced Dec 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teocomi teocomi

Labels
bug Something isn't working
Projects
None yet
Milestone
2.x
Development

No branches or pull requests
2 participants
@AlanRynne @teocomi