Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Objects: Adds tests to CI job #1621

Merged
merged 12 commits into from Sep 21, 2022

Conversation

AlanRynne
Copy link
Member

@AlanRynne AlanRynne commented Sep 20, 2022

Adds a step in build-objects to run the Objects unit tests (currently quite lacking).

Adds unit test to ensure all objects in ObjectsKit have an empty constructor implemented.

In order to not duplicate builds, build-objects will now only build:

  • Objects.csproj
  • Tests.csproj

All other projects correspond to Converters that are already being built on each of their respective Connector builds.

This also allowed to change the VM from windows to linux, which has less minute cost.

@AlanRynne AlanRynne requested a review from a team as a code owner September 20, 2022 19:44
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 42.11% // Head: 1.67% // Decreases project coverage by -40.43% ⚠️

Coverage data is based on head (8055189) compared to base (1904e9c).
Patch has no changes to coverable lines.

❗ Current head 8055189 differs from pull request most recent head 95be744. Consider uploading reports for the commit 95be744 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #1621       +/-   ##
==========================================
- Coverage   42.11%   1.67%   -40.44%     
==========================================
  Files          61     226      +165     
  Lines        5499   10065     +4566     
  Branches      821     994      +173     
==========================================
- Hits         2316     169     -2147     
- Misses       2999    9887     +6888     
+ Partials      184       9      -175     
Impacted Files Coverage Δ
Core/Core/Api/Operations/Operations.cs 0.00% <0.00%> (-100.00%) ⬇️
Core/Core/Api/GraphQL/SubscriptionModels.cs 0.00% <0.00%> (-96.43%) ⬇️
...Api/GraphQL/Serializer/NewtonsoftJsonSerializer.cs 0.00% <0.00%> (-96.16%) ⬇️
...Core/Serialisation/DeserializationWorkerThreads.cs 0.00% <0.00%> (-93.75%) ⬇️
Core/Core/Models/Extensions.cs 0.00% <0.00%> (-83.73%) ⬇️
Core/Core/Serialisation/BaseObjectSerializerV2.cs 0.00% <0.00%> (-82.21%) ⬇️
Core/Core/Transports/Utilities.cs 0.00% <0.00%> (-81.82%) ⬇️
...ore/Core/Serialisation/BaseObjectDeserializerV2.cs 0.00% <0.00%> (-80.46%) ⬇️
Core/Core/Models/DynamicBase.cs 3.40% <0.00%> (-78.41%) ⬇️
...re/Core/Api/GraphQL/Client.Subscriptions.Branch.cs 0.00% <0.00%> (-77.78%) ⬇️
... and 223 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AlanRynne
Copy link
Member Author

Disabled CodeCov upload. Should coordinate later on if we want to add these to the coverage, as we'd need to also add Core tests so that the coverage is "complete".

See current coverage report dropping from 40% to 1% because Core tests were not run (nor uploaded)

@AlanRynne AlanRynne changed the base branch from main to release/2.9 September 21, 2022 09:22
@AlanRynne AlanRynne merged commit 85b7428 into release/2.9 Sep 21, 2022
@AlanRynne AlanRynne deleted the objects/alan/default-constructor-tests branch September 21, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants