Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): Adds Blob support #1861

Merged
merged 32 commits into from Dec 13, 2022
Merged

feat(core): Adds Blob support #1861

merged 32 commits into from Dec 13, 2022

Conversation

gjedlicska
Copy link
Contributor

@gjedlicska gjedlicska commented Nov 15, 2022 •
edited

This is intended to make it in to the 2.11 release branch, do not merge it to 2.10 pls

didimitrie and others added 19 commits November 15, 2022 14:54
@didimitrie @gjedlicska
feat(core): scaffolding blob uploads (WIP)
f63ad3b
@didimitrie @gjedlicska
feat(core): blobs scaffolding
c1bb1a7
@didimitrie @gjedlicska
feat(core): blobs wip receiving
7e3b760
@didimitrie @gjedlicska
feat(core): blobs receiving first pass ✅
a41c5f7
@didimitrie @gjedlicska
feat(core): blob local cache check pre-download
c5d0dc7
@didimitrie @gjedlicska
feat(core): blobs wip
c100844
@didimitrie @gjedlicska
feat(core): more blobs wip (pre send diffing)
50b550c
@didimitrie @gjedlicska
feat(blobs): adds noise to obj and removes cache bypass hack
f7efb35
@gjedlicska
move example app to net6
bbcc6e2
@gjedlicska
remove Dim folder dependency from blob tests
d212316
@gjedlicska
fix integration test setup
51cd91f
@gjedlicska
reformat with default dotnet formatter
70d6c5e
@gjedlicska
refactor path helpers into SpecklePathProvider
db65e4e
@gjedlicska
Obsolete old path helper methods
9f91a6b
@gjedlicska
core internals visible for unittesting
6ba9eb0
@gjedlicska
sqlite transport is now an IBlobCapableTransport
84877fa
@gjedlicska
add original path to Blobs, to be able to copy data into cache on send
38696b3
@gjedlicska
add tests for blob send and receive
16fbd8a
@gjedlicska
fix failing test cases
080af98
@gjedlicska gjedlicska changed the base branch from main to release/2.10 November 15, 2022 14:45
@gjedlicska gjedlicska added this to the 2.11 milestone Nov 16, 2022
@gjedlicska
Copy link
Contributor Author

This is intended to make it in to the 2.11 release branch, do not merge it to 2.10 pls

@teocomi teocomi marked this pull request as draft November 16, 2022 10:20
@gjedlicska gjedlicska marked this pull request as ready for review December 8, 2022 09:30
@AlanRynne AlanRynne changed the base branch from release/2.10 to release/2.11 December 12, 2022 17:59
@AlanRynne
Copy link
Member

I merged changes in release/2.11 into this branch to get the CI building again

@AlanRynne AlanRynne changed the title core/blobSupport feat(core): Adds Blob support Dec 12, 2022
AlanRynne
AlanRynne approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@AlanRynne AlanRynne left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄 I'm waving my magic wand and approving this, but I still would love a demo of what this looks like on some standup!

@gjedlicska gjedlicska merged commit f5eba37 into release/2.11 Dec 13, 2022
@gjedlicska gjedlicska deleted the core/blobSupport branch December 13, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@teocomi teocomi Awaiting requested review from teocomi

@clairekuang clairekuang Awaiting requested review from clairekuang

@connorivy connorivy Awaiting requested review from connorivy

@didimitrie didimitrie Awaiting requested review from didimitrie

Assignees

@AlanRynne AlanRynne

Labels
None yet
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gjedlicska @AlanRynne @didimitrie @JR-Morgan