Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gh): Improves Rhino.Compute support with AccountToken nodes and ActiveDoc changes #2108

Merged
merged 4 commits into from Feb 8, 2023

Conversation

AlanRynne
Copy link
Member

@AlanRynne AlanRynne commented Jan 31, 2023

Adds 2 new nodes to the DEV section of Grasshopper Speckle 2.

Screenshot 2023-01-31 at 11 21 24

  • Stream Get with Token: Uses a token instead of an account as input to authenticate a user that has not been setup in Manager.
  • Get Account Token: Gets a user's account token stored in manager. This can be used to run a GH script locally that would otherwise require pasting a token in the document (very unsafe).

This would enable a Grasshopper user to design workflows that run in Rhino.Compute and allow other users to make commits on their behalf, instead of having to have a fixed user or setup the correct user on the server.

Screenshot 2023-01-31 at 11 32 35

Screenshot 2023-01-31 at 11 34 28

@AlanRynne AlanRynne requested a review from a team as a code owner January 31, 2023 09:29
@gitguardian
Copy link

gitguardian bot commented Jan 31, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@CapnK
Copy link

CapnK commented Feb 3, 2023

@AlanRynne - This would support auth when a GH script using Speckle is submitted from a users desktop machine (i.e. Get Account Token is running on a PC with the Speckle Account Manager)

Another scenario is when a GH script (using Speckle) is being invoked from a webserver.

We've also been looking at this and will be in touch with some ideas

@AlanRynne
Copy link
Member Author

AlanRynne commented Feb 3, 2023

The other scenario is also covered, Stream get with token does not use the local accounts to authenticate, it will use the provided token to fetch the account details directly from the server and create a short-lived account object. but the details of how to obtain said token and pass it as part of the GH definition inputs is responsibility of each developer.

How to securely obtain, store and pass along that token to the GH definition inputs is not something we can have control over from the GH side.

The get account token node exists for the sole purpose of testing these Gh definitions locally using hops.

Hope this brought some clarity! And if there's any edge cases you'd like us to cover don't hesitate to ping us on this!

@AlanRynne AlanRynne changed the title feat(gh): Adds new nodes to enable account authentication with a token feat(gh): Improves Rhino.Compute support with AccountToken nodes and ActiveDoc changes Feb 7, 2023
@AlanRynne AlanRynne changed the base branch from main to release/2.12 February 8, 2023 07:26
@AlanRynne AlanRynne merged commit a47a0c5 into release/2.12 Feb 8, 2023
@AlanRynne AlanRynne deleted the gh/alan/account-from-token branch February 8, 2023 07:49
@clairekuang clairekuang added grasshopper issues related to the grasshopper connector. enhancement New feature or request labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request grasshopper issues related to the grasshopper connector.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants