Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Revit): mapping on receive #2482

Merged
merged 1 commit into from Apr 27, 2023
Merged

Fix(Revit): mapping on receive #2482

merged 1 commit into from Apr 27, 2023

Conversation

connorivy
Copy link
Contributor

Description & motivation

Changes:

  • various code cleanup
  • change expected format of incoming etabs commits

Screenshots:

The dialoug shows up again
image

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

https://speckle.community/t/revit-etabs-type-mapping-issue/5466

teocomi
teocomi approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@teocomi teocomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but looks good!

@AlanRynne AlanRynne merged commit a958f8e into dev Apr 27, 2023
29 checks passed
@AlanRynne AlanRynne deleted the revit/connor/mapping-fix branch April 27, 2023 14:58
@clairekuang clairekuang added revit issues related to the revit connector. bug Something isn't working labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teocomi teocomi teocomi approved these changes

Assignees

@connorivy connorivy

Labels
bug Something isn't working revit issues related to the revit connector.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@connorivy @teocomi @AlanRynne @clairekuang