Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Curtain walls components as nested elements #2716

Closed
wants to merge 1 commit into from

Conversation

ks-cph
Copy link
Contributor

@ks-cph ks-cph commented Jun 30, 2023

Description & motivation

#1938 describes an issue with curtain walls. #2471 relates to the same problem.

Changes:

  • The adjustment creates individual instances for each component. THese components are now located in the elements of the Wall. The wall itself does no longer have a geometry.

Screenshots:

before After

Before (left) and after (right)

Each element has its own geometry now incl. the material quantities.
image

Validation of changes:

The changes have been tested with the following stream:

https://speckle.xyz/streams/e9ed27e22b

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

@connorivy connorivy self-assigned this Jun 30, 2023
@AlanRynne AlanRynne added this to the 2.16 milestone Jul 4, 2023
@AlanRynne AlanRynne added external revit issues related to the revit connector. labels Jul 6, 2023
@connorivy
Copy link
Contributor

Hey @ks-cph,

This is a good PR, but it didn't address a couple edge cases. I made a new PR #2855. Let me know if this fixes the issue for you

@ks-cph
Copy link
Contributor Author

ks-cph commented Aug 20, 2023

Hey @connorivy ,

Great, thanks! it fixes the issue. Thanks!

@connorivy connorivy closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external revit issues related to the revit connector.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants