fix:(Navisworks): progress bar should have a maxium value of 1.0 #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…calculation - Update progress bar to use a maximum value of 1.0 - Fix calculation for fractionDone to ensure it does not exceed 1
|
bound into #2766 |
jsdbroughton
deleted the
navisworks/hotfix/jsdb/partial-measurement-fail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2762
An occasional rounding error was causing some updates to the progress bar of greater than 100% (or over 1.0). This throws an error from the host application causing a failed conversion)
Changes:
For this hotfix, the Invoker method updating the progress UI has a
Math.Max(fractiondone,1)shield.TODO: Will revisit this as there are three different methodologies currently used to make traversal progress reporting - should adopt a single pattern