Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Revit) : add material quantites by mesh #3030

Merged
merged 11 commits into from
Nov 9, 2023

Conversation

connorivy
Copy link
Contributor

Description & motivation

Solves issue #2117 and improves the calculation of material quantities.

There are some problems with obtaining quantities in Revit:

RevitAPI GetMaterialIds does not return all materials
Computation of area not clear
Some categories need further evaluation

Changes:

  • Defines a few routes to retrieve material quantities
    • If the API GetMaterialArea call will return the area of a single face (instead of all faces), then it will use that method
    • If the element is a duct or pipe, then the material values can be found on the MEP system
    • Otherwise try to get the material and the area/volume from the element's mesh.

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

Child of this PR #2715

@BovineOx BovineOx added this to the 2.18 milestone Nov 9, 2023
@AlanRynne AlanRynne self-assigned this Nov 9, 2023
@AlanRynne AlanRynne modified the milestones: 2.18, 2.17 Nov 9, 2023
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just got 1 change request and a bunch of questions/considerations that are non-critical.

Copy link
Contributor

@BovineOx BovineOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things to consider

@AlanRynne AlanRynne self-requested a review November 9, 2023 16:54
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments have been resolved. We're good to go.

@AlanRynne
Copy link
Member

Added Kilian as co-author ;)

@AlanRynne AlanRynne merged commit 13b153e into dev Nov 9, 2023
30 checks passed
@AlanRynne AlanRynne deleted the revit/connor/material-quantites-add-by-mesh branch November 9, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants