Chore(props): Reduced some more subjective warnings down to suggestions/none #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(core): IDE0005 Redundant Using statements * fix(ci): GenerateDocumentationFile is required for IDE0005 to run on CI * fix(ci): Allow warnings on all CI jobs
* fix(gh): IDE0005 for Grasshopper connector * fix(rhino): IDE0005 for Rhino connector * fix(rh/gh): IDE0005 for Rhino/Grasshopper shared converter
JR-Morgan
changed the title
AlanRynne
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See build props changes
I have reduced several subjective warnings down to a
suggestionornoneI have also enabled some optional flags to make CA2000 more lenient for disposal object ownership transfers that don't quite match Microsoft ideal patterns.
see https://github.com/dotnet/roslyn-analyzers/blob/main/docs/Analyzer%20Configuration.md#dispose-analysis-kind-for-idisposable-rules
This should mean for us, the remaining CA2000 violations should all be genuine disposal issues 馃.