fix(all): CNX-7446 - ⚠️ CA1806 Fix #3090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setter never actually worked so I'm not sure what we intended to do here 🤔
…projects (#3091) fix(rhino/gh): CTX-8340 CTX-8341 - Fixes CA1806 in Rhino/Grasshopper projects
BovineOx
reviewed
Dec 5, 2023
Objects/Converters/ConverterCSI/ConverterCSIShared/PartialClasses/Analysis/ConvertModel.cs
Show resolved
Hide resolved
BovineOx
reviewed
Dec 5, 2023
Objects/Converters/ConverterCSI/ConverterCSIShared/PartialClasses/Analysis/ConvertModel.cs
Show resolved
Hide resolved
BovineOx
reviewed
Dec 5, 2023
Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/ConvertFaceWall.cs
Outdated
Show resolved
Hide resolved
BovineOx
reviewed
Dec 5, 2023
Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/ConvertFaceWall.cs
Show resolved
Hide resolved
* fix ca 1806 (mostly) * suppress warning in class --------- Co-authored-by: Connor Ivy <connor@speckle.systems>
BovineOx
reviewed
Dec 11, 2023
Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/ConvertFaceWall.cs
Outdated
Show resolved
Hide resolved
Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/ConvertGeometry.cs
Show resolved
Hide resolved
Objects/Converters/ConverterRevit/ConverterRevitShared/PartialClasses/ConvertRebar.cs
Show resolved
Hide resolved
BovineOx
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR to collect all CA1806 fixes and verify all projects are correct before merging.
This branch already contains the enforcement on CI for CA1806, all builds containing this warning will fail.