feat(rhino): CNX-8348 CNX-8349 create rhino 8 connector converter projects #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also updates preprocessor directives in converter
AlanRynne
changed the title
AlanRynne
reviewed
Dec 11, 2023
Comment on lines
+58
to
+62
| <!-- We are building for win-x64 on mac too, so these deps are not automatically copied/loaded --> | ||
| <ItemGroup Condition="'$(Configuration)'=='Debug Mac' OR '$(Configuration)'=='Release Mac'"> | ||
| <None Include="$(HOME)/.nuget/packages/avalonia.native/0.10.21/runtimes/osx/native/libAvaloniaNative.dylib" CopyToOutputDirectory="PreserveNewest" Visible="false" /> | ||
| <None Include="$(HOME)/.nuget/packages/sqlitepclraw.lib.e_sqlite3/2.1.4/runtimes/osx-x64/native/libe_sqlite3.dylib" CopyToOutputDirectory="PreserveNewest" Visible="false" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Same as here. We may also want to look into dotnet publish instead of dotnet build as it has some differences in what is copied over to the final folder.
Objects/Converters/ConverterRhinoGh/ConverterRhinoGhShared/BrepEncoder.cs
Outdated
Show resolved
Hide resolved
…instead of OR conditions
Plus remove SDK warning from connectorRhino8
AlanRynne
approved these changes
Jan 10, 2024
AlanRynne
changed the title
AlanRynne
deleted the
CNX-8348-Create-Rhino-8-Connector-Converter-projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Adds the Rhino8 connector (net7.0-windows) and converter projects. Successfully builds and loads plugin in Rhino 8.
Adds Grasshopper connector and converter projects for Rhino 8
Bumps Rhino dependencies to version 8.3
Changes:
To-do before merge:
Validation of changes: