Chore(core): CNX-7435 - Resolved even more core warnings #3109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to resolve the integration tests failing in the morning |
JR-Morgan
commented
Dec 13, 2023
JR-Morgan
requested review from
gjedlicska
and removed request for
gjedlicska
AlanRynne
reviewed
Dec 13, 2023
|
Added my 2 cents |
AlanRynne
approved these changes
Dec 19, 2023
JR-Morgan
added a commit
that referenced
this pull request
Dec 19, 2023
* More warnings resolved * More warnings * chore(core): Explicit disable nullability syntax for select files * chore(core): Nullability now default * more exception doc * Fix tests * The last warnings * removed closure throw and tracked issue for further investigation * Requested changes
JR-Morgan
added a commit
that referenced
this pull request
Dec 19, 2023
* More warnings resolved * More warnings * chore(core): Explicit disable nullability syntax for select files * chore(core): Nullability now default * more exception doc * Fix tests * The last warnings * removed closure throw and tracked issue for further investigation * Requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes with this PR:
Just 274 left!
#nullable enabledthan we had implicitly disabled), this should also encourage us to design new classes with clear nullability in mind