fix(rhino): CNX-8572 Handles ca1031 in Rhino converter files #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanRynne
approved these changes
Dec 19, 2023
AlanRynne
changed the title
|
Added Rhino ticket number to title to keep this tracked, though it's only a part of the entire fix. |
AlanRynne
deleted the
CNX-8572-Handle-CA1031-warnings-in-Rhino-Converter
branch
JR-Morgan
pushed a commit
that referenced
this pull request
Dec 19, 2023
* layer handling exceptions * Update ConverterRhinoGh.Organization.cs * Update ConverterRhinoGh.Organization.cs
JR-Morgan
pushed a commit
that referenced
this pull request
Dec 19, 2023
* layer handling exceptions * Update ConverterRhinoGh.Organization.cs * Update ConverterRhinoGh.Organization.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Handles ca1031 warnings in the rhino converter. Mostly concerns layer handling, and
CollectionToNativeconversions, including a minor fix for missing invalid chars and minor refactoring to remove duplicated local methods.Changes: