fix(Revit): CNX-8655 - handle FabricationPart host retrieval #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the `RevitCommitObjectBuilder` class to handle the retrieval of a FabricationPart's associated host element. It introduces a new private method, `HandleFabricationPart`, which processes a `FabricationPart` and returns its host element. The method checks if the `FabricationPart` has a host and retrieves it using the `GetHostedInfo()` method. The prior code would pass `null` from `GetHostedInfo()` into `GetElement()` which threw from deep withing the Revit API
jsdbroughton
added
bug
BovineOx
reviewed
Jan 4, 2024
| @@ -223,6 +223,19 @@ private static string GetCategoryId(Base conversionResult, Element revitElement) | |||
| }; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Yes, in the context of our discord chat the other day, this is much nicer to read, especially given where we are consuming it as single lines
BovineOx
approved these changes
Jan 4, 2024
jsdbroughton
deleted the
CNX-8655-MEP-Fabrication-Ductwork-not-converting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This commit refactors the
RevitCommitObjectBuilderclass to handle the retrieval of a FabricationPart's associated host element. It introduces a new private method,HandleFabricationPart, which processes aFabricationPartand returns its host element. The method checks if theFabricationParthas a host and retrieves it using theGetHostedInfo()method.The prior code would pass
nullfromGetHostedInfo()intoGetElement()which threw from deep withing the Revit APIScreenshots:
Before:
After:
Validation of changes:
Manual testing with provided test file.
Checklist: