chore(objects): Resolve namespace warnings #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
approved these changes
Jan 15, 2024
JR-Morgan
reviewed
Jan 15, 2024
| using Speckle.Core.Kits; | ||
| using Speckle.Core.Models; | ||
|
|
||
| namespace Objects.BuiltElements.Revit.RevitRoof; |
There was a problem hiding this comment.
I see this one still generates a warning... But this namespace is questionable at best.
Perhaps we can use our "deprecated" namespacing feature of the serializer to deprecate + move these incorrectly namespace classes.
Perhaps to be done in another PR
There was a problem hiding this comment.
Hmm for now I've created a RevitRoof folder for this file, but it does seem like the namespace is incorrect. We can fix these in another ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts folder structure for all namespace warnings in
Objects. Organization is based on namespaces - no namespaces were adjusted.