chore(objects): CNX-8709 suppress warnings in obsolete classes, methods, and fields #3143
Conversation
…com:specklesystems/speckle-sharp into CNX-8709-Objects-Obsolete-remove-or-supress
| @@ -32,6 +32,8 @@ int endIndex | |||
| IsoStatus = isoStatus; | |||
| TrimType = trimType; | |||
| IsReversed = reversed; | |||
| StartIndex = startIndex; | |||
There was a problem hiding this comment.
Why were we not doing this before?
There was a problem hiding this comment.
I'm not sure, @AlanRynne was there a reason you can remember for not setting the StartIndex and EndIndex props even though they are arguments passed to the constructor?
There was a problem hiding this comment.
I find no reason why we would ever do this, I'll dig in a bit more after standup.
There was a problem hiding this comment.
I double checked the usages of this constructor and it is definitely a bug/oversight.
This does not affect conversions for the most part, as the start/end vertex index is rarely used... but I'm sure this would fix some odd Brep edge-cases we may have been unaware of.
It will also ensure breps always have the same id (as missing to set start/end vertex would in fact result in a different id for that brep)
AlanRynne
changed the title
| @@ -32,6 +32,8 @@ int endIndex | |||
| IsoStatus = isoStatus; | |||
| TrimType = trimType; | |||
| IsReversed = reversed; | |||
| StartIndex = startIndex; | |||
There was a problem hiding this comment.
I double checked the usages of this constructor and it is definitely a bug/oversight.
This does not affect conversions for the most part, as the start/end vertex index is rarely used... but I'm sure this would fix some odd Brep edge-cases we may have been unaware of.
It will also ensure breps always have the same id (as missing to set start/end vertex would in fact result in a different id for that brep)
Networkclass and related classes are now marked asObsolete(instead of just the constructor).