Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(archicad): CNX-8304 fix ide0005 in archicad #3150

Merged
merged 4 commits into from
Jan 26, 2024
Merged

chore(archicad): CNX-8304 fix ide0005 in archicad #3150

merged 4 commits into from
Jan 26, 2024

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Jan 23, 2024 •
edited

Archicad:

  • Fixed warning as error violations in Archicad projects

Build/CI:

  • Added desktopbuild false for dotnet publish builds
  • Added all level 1 warnings (Except those that had violations) to our build props (enforced for all builds)

@JR-Morgan JR-Morgan force-pushed the CNX-8304-Fix-IDE0005-in-Archicad branch from 7bb7f09 to 82048be Compare January 23, 2024 20:47
@JR-Morgan JR-Morgan force-pushed the CNX-8304-Fix-IDE0005-in-Archicad branch from 82048be to b752304 Compare January 23, 2024 20:48
@JR-Morgan JR-Morgan marked this pull request as ready for review January 23, 2024 20:48
@JR-Morgan JR-Morgan added this to the 2.18 milestone Jan 25, 2024
AlanRynne
AlanRynne approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch Jedd 🙌🏼

@AlanRynne AlanRynne merged commit 71e4797 into dev Jan 26, 2024
32 checks passed
@AlanRynne AlanRynne deleted the CNX-8304-Fix-IDE0005-in-Archicad branch January 26, 2024 09:04
@JR-Morgan JR-Morgan mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@jozseflkiss jozseflkiss jozseflkiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JR-Morgan @AlanRynne @jozseflkiss