Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNX-9043 update server info return type and queries to include new migration property #3201

Merged
merged 21 commits into from
Mar 1, 2024
Merged

CNX-9043 update server info return type and queries to include new migration property #3201

merged 21 commits into from
Mar 1, 2024

Conversation

connorivy
Copy link
Contributor

Description & motivation

Add new account properties to track if a user's account has been upgraded from an FE1 account

Changes:

Add movedTo and movedFrom props to ServerInfo object
Modify graphQL queries to include the movedFrom and movedTo info

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@connorivy connorivy marked this pull request as draft February 28, 2024 14:21
@JR-Morgan JR-Morgan changed the base branch from dev to main February 28, 2024 15:31
Connor Ivy added 4 commits February 28, 2024 14:04
add server version check
81caacc
Revert "Merge remote-tracking branch 'origin/dui/stream-card-fe2-upgr…
776015f 
…ade' into core/connor/server-info"

This reverts commit f143115, reversing
changes made to 6ace471.
Merge branch 'core/connor/server-info' into CNX-9043-Update-serverInf…
4e448e5 
…o-return-type-and-queries-to-include-new-migration-property
add matteo's Upgrade method
8df6323
AlanRynne
AlanRynne requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got many questions hehe 😅🙌🏼

Core/Core/Api/GraphQL/GraphQLHttpClientExtensions.cs Show resolved Hide resolved
Core/Core/Credentials/AccountManager.cs Show resolved Hide resolved
Core/Core/Credentials/AccountManager.cs Outdated Show resolved Hide resolved
Core/Core/Credentials/AccountManager.cs Outdated Show resolved Hide resolved
Core/Core/Helpers/Http.cs Show resolved Hide resolved
Core/Core/Api/GraphQL/Models.cs Outdated Show resolved Hide resolved
Core/Core/Api/GraphQL/GraphQLHttpClientExtensions.cs Outdated Show resolved Hide resolved
@AlanRynne AlanRynne changed the title Cnx 9043 update server info return type and queries to include new migration property CNX-9043 update server info return type and queries to include new migration property Feb 29, 2024
@connorivy connorivy marked this pull request as ready for review February 29, 2024 17:11
@AlanRynne AlanRynne merged commit 8b5a712 into main Mar 1, 2024
32 checks passed
@AlanRynne AlanRynne deleted the CNX-9043-Update-serverInfo-return-type-and-queries-to-include-new-migration-property branch March 1, 2024 20:03
@JR-Morgan JR-Morgan mentioned this pull request Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@JR-Morgan JR-Morgan JR-Morgan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@connorivy @AlanRynne @JR-Morgan @teocomi