CNX-8975: mixpanel metrics for grasshopper and dynamo are incorrectly logged as rhino revit #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanRynne
changed the title
AlanRynne
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
In addition to the necessary changes in Rhino/Grasshopper and Revit/Dynamo, I have fixed a disposal bug on the Analytics class.
Disposal and async calls were running into a race condition. I also stopped using the proxy HTTP client and instead used a generic one, logging performance metrics for analytics calls is overkill.
JR-Morgan
commented
Mar 8, 2024
JR-Morgan
commented
Mar 8, 2024
Also set the Global.RevitDocument on startup
AlanRynne
deleted the
CNX-8975-Mixpanel-Metrics-for-Grasshopper-Dynamo-are-incorrectly-logged-as-Rhino-Revit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.