Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #3222 #3232

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Fix for issue #3222 #3232

merged 3 commits into from
Apr 11, 2024

Conversation

andreaslennartz
Copy link
Contributor

As discussed in #3222

@JR-Morgan JR-Morgan added bug Something isn't working core issues related to the .net sdk. labels Mar 15, 2024
@JR-Morgan JR-Morgan added this to the 2.19 milestone Mar 15, 2024
@JR-Morgan
Copy link
Member

Thanks 🙌,

I want to discuss this change a little with @connorivy (who's currently on holiday, so it will be next week we get round to reviewing it unfortunately).

@andreaslennartz
Copy link
Contributor Author

Sure, no rush. Thanks for looking into this!

@bimgeek
Copy link
Contributor

bimgeek commented Apr 8, 2024

Hey @andreaslennartz ,

Thanks for the PR. I have scheduled a ticket to review and include this in, in our next sprint(starting Wednesday).

@JR-Morgan JR-Morgan merged commit 540b0d1 into specklesystems:dev Apr 11, 2024
31 checks passed
@JR-Morgan
Copy link
Member

JR-Morgan commented Apr 11, 2024

Hi @andreaslennartz
We've merged this into our dev branch, the change will be part of our 2.19 nugets (I don't have a release date for you just yet, it will be at least a few weeks away)

Due to the way we merge commits to dev first (with a squash merge), your fork's main branch is now out of sync with ours (just as a heads up if you ever wanted to contribute another pr in future, you may want to reset your main branch to avoid conflicts)

Thanks for the contribution! 🙌

@andreaslennartz
Copy link
Contributor Author

Hi @JR-Morgan ,
thanks for the merge and the heads-up!
Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core issues related to the .net sdk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SetRelationship (in CommitObjectBuilder) throws "an item with the same key has already been added" exception
4 participants