Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(logging): profile union and set calls to analytics #3256

Merged
merged 3 commits into from
Apr 5, 2024

Conversation

teocomi
Copy link
Member

@teocomi teocomi commented Apr 3, 2024

The profile-union and profile-set calls cannot be combined and were failing silently; this fixes that.
I'm pointing to main but this can go in any time, also in the next release.

@teocomi teocomi added bug Something isn't working core issues related to the .net sdk. labels Apr 3, 2024
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's combine this and the other analytics improvements by Claire in #3257 and make a pre-release to ensure both work right

@clairekuang clairekuang self-requested a review April 5, 2024 11:53
@AlanRynne AlanRynne merged commit b025200 into main Apr 5, 2024
32 checks passed
@AlanRynne AlanRynne deleted the matteo/core/logging-fix branch April 5, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core issues related to the .net sdk.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants