Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNX-9206 - Adds Navis2025 support #3260

Merged
merged 6 commits into from
Apr 8, 2024
Merged

CNX-9206 - Adds Navis2025 support #3260

merged 6 commits into from
Apr 8, 2024

Conversation

jsdbroughton
Copy link
Contributor

@jsdbroughton jsdbroughton commented Apr 5, 2024 •
edited

Needs Innosetup files to be updated to match

@jsdbroughton jsdbroughton changed the title Adds Navis2025 support CNX-9206 - Adds Navis2025 support Apr 5, 2024
BovineOx
BovineOx previously requested changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@BovineOx BovineOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's just a debug line that needs to come out...

ConnectorNavisworks/ConnectorNavisworks/Entry/Ribbon.xaml.cs Outdated Show resolved Hide resolved
AlanRynne
AlanRynne approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my eyes... all is good.

BovineOx
BovineOx approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@BovineOx BovineOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I see how that messagebox was used, I don't think I saw the whole context....

@jsdbroughton jsdbroughton merged commit e64f68d into dev Apr 8, 2024
32 checks passed
@jsdbroughton jsdbroughton deleted the jsdb/Navis2025 branch April 8, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanRynne AlanRynne AlanRynne approved these changes

@BovineOx BovineOx BovineOx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsdbroughton @AlanRynne @BovineOx