perf(civil): CNX-9178 Civil: Optimised ToSpeckle conversion performance of Tin Surfaces #3274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
changed the title
…unacceptable-performance-ToSpeckle-
clairekuang
requested changes
Apr 10, 2024
.../Converters/ConverterAutocadCivil/ConverterAutocadCivilShared/ConverterAutocadCivil.Civil.cs
Outdated
Show resolved
Hide resolved
...nverters/ConverterAutocadCivil/ConverterAutocadCivilShared/ConverterAutocadCivil.Geometry.cs
Show resolved
Hide resolved
…e-performance-ToSpeckle-' of https://github.com/specklesystems/speckle-sharp into CNX-9178-Civil3D-TinSurfaces-conversion-has-unacceptable-performance-ToSpeckle-
…unacceptable-performance-ToSpeckle-
clairekuang
approved these changes
Apr 10, 2024
JR-Morgan
deleted the
CNX-9178-Civil3D-TinSurfaces-conversion-has-unacceptable-performance-ToSpeckle-
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with the small surface test files, and no regressions (object ids perfectly match)
I'm not able to test any large surfaces, due to receive performance being awful still.