CNX-9205 : Properly initialize connector on Revit file double-click #3311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
AlanRynne
approved these changes
Apr 25, 2024
BovineOx
approved these changes
Apr 25, 2024
| RevitApp.Application.DocumentOpening += Application_DocumentOpening; | ||
| // This code may fire during the DocumentOpening event, in which case an exception will be | ||
| // thrown about being unable to subscribe to an event during that event | ||
| //RevitApp.Application.DocumentOpening += Application_DocumentOpening; |
There was a problem hiding this comment.
Should we comment this out or maybe just rephrase this in the comment to say Removed hooking to DocumentOpening event because....
There was a problem hiding this comment.
Just makes it clear as opposed to commented out code, which reads ambiguous, like we might need a solution to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
properly initialize revit plugin on file double-click
Changes:
References
#1469
Original issue describing the problem in more detail
#3255
External PR that figured out how to fix the issue. We let it get too out of date and the logic was fairly straightforward so instead of resolving merge conflicts, I just made a new PR.