Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Revit) : Use speckle newtonsoft instead of System.Text.Json for in dll conflict management project #3317

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

connorivy
Copy link
Contributor

Description & motivation

Once Bilal upgraded to the connector version with dll conflict mangement, he was met with the conflict dialog option even though previosly he wasn't running into any conflicts.

Turns out that the only dependency introduced in the dll conflict manager, System.Text.Json, caused a new conflict. In this PR I replaced System.Text.Json with Speckle.Newtonsoft.

I also introduced a new way to exclude conflicts because bilal was getting a conflict between our version of RevitAPI.dll. Now we are ignoring a conflict if the conflicting dll is a Revit dll.

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

@AlanRynne
Copy link
Member

Ouch, that one did not take long.... #3273 (comment) 😅

Copy link
Member

@AlanRynne AlanRynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good 🙌🏼 We should have used our own Newtonsoft from the get go 😢

@AlanRynne AlanRynne merged commit 612ff3f into dev Apr 29, 2024
32 checks passed
@AlanRynne AlanRynne deleted the revit/connor/speckle-newtonsoft branch April 29, 2024 07:53
@connorivy
Copy link
Contributor Author

@AlanRynne

First thing I said when Bilal showed me this was, "Well, Alan called it"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants