Do not log connector output by default #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @gasparnagy here is a little change which - I believe - can make a big difference. The Azure pipeline failed to download .NET 5. As far as I can tell, this is a known random issue, a retry should be enough to let it go through. (reference: microsoft/azure-pipelines-tasks#15086) |
|
I see the problem. I agree that that detail is not needed by default in the log. It is not practical to condition it to (Ideally Deveroom should delete log files older than 10 days or so...) |
The current implementation of `OutProcSpecFlowConnector` logs the full output of the specflow connector to the log file, and to VS debug window. On a project with a lot of tests, each log file can amount to a massive size (on my machine, I have 2.6 GB of Deveroom logs from regular usage since late 2019, and the biggest daily log files are ~160 MB). This impacts both the machine disk space, and the performance of the extension itself. Here we adjust `OutProcSpecFlowConnector` to only log in a debug build.
|
Thanks @gasparnagy ! I have updated the commit to use |
|
@tlecomte Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
OutProcSpecFlowConnectorlogs the full output of the specflow connector to the log file, and to VS debug window.On a project with a lot of tests, each log file can amount to a massive size (on my machine, I have 2.6 GB of Deveroom logs from regular usage since late 2019, and the biggest daily log files are ~160 MB).
This impacts both the machine disk space, and the performance of the extension itself.
Here we adjust
OutProcSpecFlowConnectorto only log in a debug build.