Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make expect the default instead of EXP_expect #124

Closed
orta opened this issue Dec 27, 2014 · 9 comments
Closed

Make expect the default instead of EXP_expect #124

orta opened this issue Dec 27, 2014 · 9 comments

Comments

@orta
Copy link
Member

orta commented Dec 27, 2014

I've started using Expecta as a dynamic framework. I came upon a pretty serious issue that I have to have silly looking matchers as frameworks don't seem to allow app-level #definesto make changes to external codebases. e.g.

  #define EXP_SHORTHAND
  @import Specta;
  @import Expecta;

Will ignore the EXP_SHORTHAND declaration, and I can only use EXP_expect(x).to.equal(y). It probably made sense to do the EXP_expect to avoid naming collisions. But does anyone really not use it? The whole point is to have readable tests, and so everyone just has to add another line of code.

@orta
Copy link
Member Author

orta commented Dec 28, 2014

@robb
Copy link
Member

robb commented Dec 28, 2014

I'd be all for flipping the default, but semver theoretically requires a major release for that, right?

@orta
Copy link
Member Author

orta commented Dec 28, 2014

IMO, yes, but given that it's pre 0, a patch may be fine?

@robb
Copy link
Member

robb commented Dec 28, 2014

Oh, right. 👍 from me then

@ashfurrow
Copy link
Contributor

Me, too. Just got caught by the same issue. @orta your solution was just using EXP_expect()?

@orta
Copy link
Member Author

orta commented Jan 3, 2015

yes

@orta orta mentioned this issue Feb 7, 2015
9 tasks
@orta
Copy link
Member Author

orta commented Feb 11, 2015

holding off on structural changes until #128 is merged

@tonyarnold
Copy link
Contributor

I've actually done this as part of the work for #128, so feel free to close this out in favour of that PR.

@orta
Copy link
Member Author

orta commented Feb 11, 2015

Giphy

@orta orta closed this as completed Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants