-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make expect the default instead of EXP_expect #124
Comments
I'd be all for flipping the default, but semver theoretically requires a major release for that, right? |
IMO, yes, but given that it's pre |
Oh, right. 👍 from me then |
Me, too. Just got caught by the same issue. @orta your solution was just using |
yes |
holding off on structural changes until #128 is merged |
I've actually done this as part of the work for #128, so feel free to close this out in favour of that PR. |
I've started using Expecta as a dynamic framework. I came upon a pretty serious issue that I have to have silly looking matchers as frameworks don't seem to allow app-level
#defines
to make changes to external codebases. e.g.Will ignore the
EXP_SHORTHAND
declaration, and I can only useEXP_expect(x).to.equal(y)
. It probably made sense to do theEXP_expect
to avoid naming collisions. But does anyone really not use it? The whole point is to have readable tests, and so everyone just has to add another line of code.The text was updated successfully, but these errors were encountered: