-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with Xcode 6 beta #83
Conversation
+1, confirmed this pull request gets specs to build! However, the Specta unit tests still fail on the latest version of Xcode, even with this change. |
Another issue on the latest version of Xcode: Instead of individual example names, Because each of the invocations has the same name, only one appears, even when multiple examples are defined. @robb I'd recommend merging this PR, then creating separate issues for (1) unit test failures and (2) the above regression. If you're at WWDC you might want to speak to someone, or file a radar. |
Uh oh, I was so concentrated on getting Specta to build so I missed this obvious bug, my fault. As far as I remember XCTest team is not willing to support 3rd party tools relying on XCTest. I filed radar against XCTest last year and they said they will not going to fix it. |
+1 |
Another issue to note: because all tests now have the same name (i.e.: |
This looks pretty elaborate. Why not this? #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 80000 // __IPHONE_8_0
#else
#endif |
@dblock well, you know… it looks good. However the more I think about the issue the more I want to suggest XCTest authors to add some kind of versioning to their framework. What do you think of this? |
Yes, a #define could be useful. However isn't it always shipping with the SDK, and hence is in sync? |
I guess you're right |
Does this work on OS X? I see a reference to iOS 6 in the code, but I assume you're just testing for the existence of a selector that was present on both platforms? |
There is no ref to iOS 6 but Xcode 6 |
You're right — my apologies. I read that wrong! |
Xcode 6 support is being worked on in "https://github.com/specta/specta/tree/0.3-wip" branch. |
Fixes #82