Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spectcl emitting events before listeners can be bound #136

Closed
ryanbmilbourne opened this issue Oct 4, 2016 · 0 comments
Closed

Spectcl emitting events before listeners can be bound #136

ryanbmilbourne opened this issue Oct 4, 2016 · 0 comments
Assignees
@ryanbmilbourne
Labels
bug

Comments

@ryanbmilbourne
Copy link
Contributor

Description of the bad behavior

Occasionally data/error/exit events are being emitted before the listeners can be bound.

Version of spectcl showing said bad behavior

0.6.2

Description of how to reproduce the problem

Use spectcl with many (>25) active sessions.

Description of the expected behavior

Spectcl should responsibly emit events.
@ryanbmilbourne ryanbmilbourne self-assigned this Oct 4, 2016
ryanbmilbourne added a commit to ryanbmilbourne/spectcl that referenced this issue Oct 4, 2016
@ryanbmilbourne
Fix issues with event emission and send throwing
8a4f21a 
This commit fixes two scalability issues I identified in lab.  First, we
will defer event emissions to ensure that the listners can register
their callbacks.  Second, we add some defensive coding around the
session child writing to handle write errors gracefully.

Tested in our lab, with 75+ concurrent telnet sessions.

fixes spectcl#135, fixes spectcl#136
@ryanbmilbourne ryanbmilbourne mentioned this issue Oct 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanbmilbourne ryanbmilbourne

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryanbmilbourne