Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npm audits #177

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Fix npm audits #177

merged 1 commit into from
Oct 25, 2019

Conversation

gcochard
Copy link
Member

What does this Pull Request do?

Updates a bunch of deps to squelch npm audit warnings.

Where should the maintainers start when reviewing your request?

package.json

Is there any additional background context you'd like to provide?

npm audit now warns if packages have vulnerabilities. These vulns were in dev dependencies and generally apply to user-input handling code, but the deps needed updating anyway.

Are there any relevant issues?

No

Questions:

  • Does this request add new dependencies to spectcl? No
  • Does this request constitute a MAJOR change to spectcl's version? No

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.567% when pulling 4b1a3fb on npm-audit-fixes into 5bf6a4d on master.

@gcochard
Copy link
Member Author

All tests passing, coveralls still reporting. Merging.

@gcochard gcochard merged commit 660e607 into master Oct 25, 2019
@gcochard gcochard deleted the npm-audit-fixes branch October 25, 2019 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants