Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install #41

Merged
merged 4 commits into from Jan 30, 2020
Merged

Fix install #41

merged 4 commits into from Jan 30, 2020

Conversation

jdavid
Copy link
Member

@jdavid jdavid commented Jan 29, 2020 •
edited

  • Update requirements, so it builds & installs again. Fix unit tests and some warnings.
  • Do not require bcolz, so reflexible can be installed without it.
  • Fix travis.

@jdavid
refactoring
db0ed5e
@jdavid
Fix install and tests
f93c5e1 
Update requirements. Fixes some warnings as well.
@jdavid
Do not require bcolz
cdc8666 
bcolz has build/install problems, e.g.
Blosc/bcolz#398
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 50.319% when pulling f5bbda3 on jdavid:fixinstall into df523f9 on spectraphilic:master.

@FrancescAlted
Copy link
Member

Was the intention to remove bcolz? Because I see that you are importing it in more modules.

@jdavid
Copy link
Member Author

jdavid commented Jan 29, 2020

No, I'm importing it in the same modules, just moved the import statement inside the functions that need it.

Would be nice to replace bcolz so these functions work without, but that would be much more work, and replaced by what? I don't know the code enough.

@FrancescAlted
Copy link
Member

Ah sorry. I thought the intention was to remove the need for bcolz completely, but this is not the case. Other than that, this looks good to me!

@jdavid jdavid merged commit e4af51a into spectraphilic:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrancescAlted FrancescAlted FrancescAlted approved these changes

@jfburkhart jfburkhart Awaiting requested review from jfburkhart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jdavid @coveralls @FrancescAlted